2 patches: one for spelling/typos, one for working with UBSan/TSan

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

2 patches: one for spelling/typos, one for working with UBSan/TSan

Sean McBride
Hi there,

Attached are 2 patches, both from local changes in the ITK project (www.itk.org) that I'm hoping to upstream:

- a trivial one fixing spelling mistakes
- another one that suppresses UBSan & TSan from complaining about all the nastiness done in H5Detect.c

Cheers,

--
____________________________________________________________
Sean McBride, B. Eng                 [hidden email]
Rogue Research                        www.rogue-research.com
Mac Software Developer              Montréal, Québec, Canada

_______________________________________________
Hdf-forum is for HDF software users discussion.
[hidden email]
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5

0001-Fixed-various-spelling-mistakes-mostly-in-comments.patch (13K) Download Attachment
0002-Workaround-undefined-behaviour-in-H5Detect.c.patch (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: 2 patches: one for spelling/typos, one for working with UBSan/TSan

bljones
Hi Sean,

I entered bug reports for both issues:

   HDFFV-10345 - for 0001-Fixed-various-spelling-mistakes-mostly-in-comments.patch
   HDFFV-10346 - for 0002-Workaround-undefined-behaviour-in-H5Detect.c.patch

Thank you!
-Barbara
[hidden email]

-----Original Message-----
From: Hdf-forum [mailto:[hidden email]] On Behalf Of Sean McBride
Sent: Wednesday, December 06, 2017 2:16 PM
To: HDF Users Discussion List
Subject: [Hdf-forum] 2 patches: one for spelling/typos, one for working with UBSan/TSan

Hi there,

Attached are 2 patches, both from local changes in the ITK project (www.itk.org) that I'm hoping to upstream:

- a trivial one fixing spelling mistakes
- another one that suppresses UBSan & TSan from complaining about all the nastiness done in H5Detect.c

Cheers,

--
____________________________________________________________
Sean McBride, B. Eng                 [hidden email]
Rogue Research                        www.rogue-research.com
Mac Software Developer              Montréal, Québec, Canada

_______________________________________________
Hdf-forum is for HDF software users discussion.
[hidden email]
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5
Reply | Threaded
Open this post in threaded view
|

Re: 2 patches: one for spelling/typos, one for working with UBSan/TSan

Sean McBride
In reply to this post by Sean McBride
And that bug database is not public, right?

Please relate HDFFV-10346 to HDFFV-8147 (the latter I reported half a decade ago, and I assume you'll never fix :(, hence the workaround).

Cheers,

Sean


On Wed, 6 Dec 2017 21:22:20 +0000, Barbara Jones said:

>Hi Sean,
>
>I entered bug reports for both issues:
>
>   HDFFV-10345 - for 0001-Fixed-various-spelling-mistakes-mostly-in-
>comments.patch
>   HDFFV-10346 - for 0002-Workaround-undefined-behaviour-in-H5Detect.c.patch
>
>Thank you!
>-Barbara
>[hidden email]
>
>-----Original Message-----
>From: Hdf-forum [mailto:[hidden email]] On Behalf
>Of Sean McBride
>Sent: Wednesday, December 06, 2017 2:16 PM
>To: HDF Users Discussion List
>Subject: [Hdf-forum] 2 patches: one for spelling/typos, one for working
>with UBSan/TSan
>
>Hi there,
>
>Attached are 2 patches, both from local changes in the ITK project
>(www.itk.org) that I'm hoping to upstream:
>
>- a trivial one fixing spelling mistakes
>- another one that suppresses UBSan & TSan from complaining about all
>the nastiness done in H5Detect.c
>
>Cheers,
>
>--
>____________________________________________________________
>Sean McBride, B. Eng                 [hidden email]
>Rogue Research                        www.rogue-research.com
>Mac Software Developer              Montréal, Québec, Canada
>
>_______________________________________________
>Hdf-forum is for HDF software users discussion.
>[hidden email]
>http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
>Twitter: https://twitter.com/hdf5



_______________________________________________
Hdf-forum is for HDF software users discussion.
[hidden email]
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5
Reply | Threaded
Open this post in threaded view
|

Re: 2 patches: one for spelling/typos, one for working with UBSan/TSan

bljones
Hi Sean,

Yes, the bug database is not yet public. Please note the following in the recent announcement about the alpha release of the new Support Portal:

o Once we launch, we'll turn our focus to enhancing our support capabilities by connecting this site to your hdfgroup.org account, which will allow us to:
 Let you access, monitor, and manage your help-desk support requests through an interactive interface.
 Grant you access to browse, comment, and vote on our software bug tracking databases.

Yes, HDFFV-8147 is closed and will not be fixed. I added a note about HDFFV-8147 to bug HDFFV-10346.

-Barbara

-----Original Message-----
From: Sean McBride [mailto:[hidden email]]
Sent: Wednesday, December 06, 2017 3:28 PM
To: HDF Users Discussion List; Barbara Jones
Subject: Re: [Hdf-forum] 2 patches: one for spelling/typos, one for working with UBSan/TSan

And that bug database is not public, right?

Please relate HDFFV-10346 to HDFFV-8147 (the latter I reported half a decade ago, and I assume you'll never fix :(, hence the workaround).

Cheers,

Sean


On Wed, 6 Dec 2017 21:22:20 +0000, Barbara Jones said:

>Hi Sean,
>
>I entered bug reports for both issues:
>
>   HDFFV-10345 - for 0001-Fixed-various-spelling-mistakes-mostly-in-
>comments.patch
>   HDFFV-10346 - for
>0002-Workaround-undefined-behaviour-in-H5Detect.c.patch
>
>Thank you!
>-Barbara
>[hidden email]
>
>-----Original Message-----
>From: Hdf-forum [mailto:[hidden email]] On Behalf
>Of Sean McBride
>Sent: Wednesday, December 06, 2017 2:16 PM
>To: HDF Users Discussion List
>Subject: [Hdf-forum] 2 patches: one for spelling/typos, one for working
>with UBSan/TSan
>
>Hi there,
>
>Attached are 2 patches, both from local changes in the ITK project
>(www.itk.org) that I'm hoping to upstream:
>
>- a trivial one fixing spelling mistakes
>- another one that suppresses UBSan & TSan from complaining about all
>the nastiness done in H5Detect.c
>
>Cheers,
>
>--
>____________________________________________________________
>Sean McBride, B. Eng                 [hidden email]
>Rogue Research                        www.rogue-research.com
>Mac Software Developer              Montréal, Québec, Canada
>
>_______________________________________________
>Hdf-forum is for HDF software users discussion.
>[hidden email]
>http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
>Twitter: https://twitter.com/hdf5


_______________________________________________
Hdf-forum is for HDF software users discussion.
[hidden email]
http://lists.hdfgroup.org/mailman/listinfo/hdf-forum_lists.hdfgroup.org
Twitter: https://twitter.com/hdf5